st_widget_get_theme_node: g_error if called on an unparented widget

It's wrong to do anything that requires looking up a widget's style
before you add the widget to the stage, since its final style may
depend on properties inherited from its parents.
st_widget_get_theme_node() used to emit a warning in this case, but
many would-be contributors apparently didn't notice. Help them out.

https://bugzilla.gnome.org/show_bug.cgi?id=610279

diff --git a/src/st/st-widget.c b/src/st/st-widget.c
index 4a674c5be8b9b8223f9794a7d0757fe813e15f1f..08768f73be147c887e38333bfc08b1fd527a1eee 100644 (file)
--- a/src/st/st-widget.c
+++ b/src/st/st-widget.c
@@ -1101,8 +1101,7 @@ st_widget_get_theme_node (StWidget *widget)
 
       if (stage == NULL)
         {
-          g_warning ("st_widget_get_theme_node called on a widget not in a stage");
-          stage = CLUTTER_STAGE (clutter_stage_get_default ());
+          g_error ("st_widget_get_theme_node called on a widget not in a stage");
         }
 
       if (parent_node == NULL)